Skip to content

Fix BOTAN_INCLUDE_DIR usage - #179

Open
butteronarchbtw wants to merge 1 commit into
randombit:masterfrom
butteronarchbtw:fix-botan-include-dir-usage
Open

Fix BOTAN_INCLUDE_DIR usage#179
butteronarchbtw wants to merge 1 commit into
randombit:masterfrom
butteronarchbtw:fix-botan-include-dir-usage

Conversation

@butteronarchbtw

Copy link
Copy Markdown

The readme in botan-sys suggests that if botan headers can be found in foo/botan-3/botan, BOTAN_INCLUDE_DIR should only be set to foo/, implying that the botan-3/botan path will be added by the build system.
Currently, for the default search paths, the botan-{major-version} suffix is appended to the basepath, but not to BOTAN_INCLUDE_DIR if it is set, i.e. it would need to be set to foo/botan-3, which does not adhere to the readme.

I've provided a draft implementation that searches in BOTAN_INCLUDE_DIR/botan-{3,2} just like it does for the default paths.

That however would prohibit the user to provide things such as foo/botan/ for the BOTAN_INCLUDE_DIR, where the headers are directly contained in foo/botan/, so the simpler fix could just be to update the readme :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant